Skip to content

Install and require at least ruby 3.1 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Feb 23, 2025

No description provided.

@postmodern
Copy link
Member

@moozzi I wonder if GitHub Actions is running the commands under bash instead of zsh or if zsh isn't loading the ~/.zshrc file the script modifies?

@moozzi
Copy link
Member Author

moozzi commented Feb 23, 2025

@postmodern homebrew_install_ruby()is not even called because macos-latest ships with ruby 3.0.7

@postmodern
Copy link
Member

postmodern commented Feb 23, 2025

Ah ha. We need to upgrade the ruby_version check for >= 3.1.0. Maybe something like:

if [[ -z "$ruby_version" ]] || [[ "$ruby_version" == "2."* ]] || [[ "$ruby_version" == "3.0."* ]]; then

@moozzi moozzi force-pushed the fix_ruby_3-0_vs_3-1 branch 15 times, most recently from 84d17ce to c07cc2e Compare February 23, 2025 16:01
@moozzi moozzi changed the title test Install and require at least ruby 3.1 Feb 23, 2025
@moozzi moozzi marked this pull request as ready for review February 23, 2025 16:04
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Style suggestion.
  • Need to do the same fix to ronin-install.sh and test/ronin_install_test.sh as well.

@moozzi moozzi force-pushed the fix_ruby_3-0_vs_3-1 branch from 680263b to 2e8c864 Compare February 24, 2025 07:06
@postmodern postmodern merged commit dca6ac6 into ronin-rb:main Feb 24, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants