-
Notifications
You must be signed in to change notification settings - Fork 5
Migration to Svelte 5 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for svelte-sortable-list failed.
|
Hey, @terrakuh! I very much appreciate the time and effort you put on this PR. I haven’t learnt Svelte 5 properly yet, so this was very enlightening :) I gotta tell you I’ve just published a new version with the auto scroll feature. On top of that, I’ve started working on a refactor of the whole package, including things like changes in the elements structure, addition of new events and removal of the current ones, and customization of the screen reader messages, among other things. So in all honesty, we might only be able to use this PR as reference for the migration. Otherwise, it would need quite an update once the refactoring is finished. |
Hi @rodrigodagostino , that auto scroll feature looks really cool. |
PS: For starters I think setting Svelte as a peer dependency to |
Yes, I think it would make the most sense to close since resolving the current conflicts and the upcoming ones might require more effort than simply working on the migration with a clean slate after the refactoring, but we can keep it open until we reach the migration stage :) And thank you very much for that last tip! I will keep it in mind :) |
Thank you for the library :) |
7fed374
to
c3a67f7
Compare
I migrated your beautiful project to Svelte 5 without backward compatibility. For the events I chose the props approach instead of a custom component and bubbling events. This is done via another context.
I'd like your feedback if this is going in the direction you hoped for.
Would close #10