Skip to content

Migration to Svelte 5 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

terrakuh
Copy link

I migrated your beautiful project to Svelte 5 without backward compatibility. For the events I chose the props approach instead of a custom component and bubbling events. This is done via another context.

I'd like your feedback if this is going in the direction you hoped for.

Would close #10

Copy link

vercel bot commented May 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-sortable-list ❌ Failed (Inspect) May 17, 2025 10:16am

Copy link

netlify bot commented May 17, 2025

Deploy Preview for svelte-sortable-list failed.

Name Link
🔨 Latest commit 4d276f3
🔍 Latest deploy log https://app.netlify.com/projects/svelte-sortable-list/deploys/68286201aa27690008d41ad8

@rodrigodagostino
Copy link
Owner

Hey, @terrakuh! I very much appreciate the time and effort you put on this PR. I haven’t learnt Svelte 5 properly yet, so this was very enlightening :)

I gotta tell you I’ve just published a new version with the auto scroll feature. On top of that, I’ve started working on a refactor of the whole package, including things like changes in the elements structure, addition of new events and removal of the current ones, and customization of the screen reader messages, among other things.

So in all honesty, we might only be able to use this PR as reference for the migration. Otherwise, it would need quite an update once the refactoring is finished.

@terrakuh
Copy link
Author

Hi @rodrigodagostino , that auto scroll feature looks really cool.
Don't worry, I would be happy if the PR can somehow be a reference for you :) Should I close this PR then?

@terrakuh
Copy link
Author

PS: For starters I think setting Svelte as a peer dependency to "svelte": "^4.0.0 || ^5.0.0" should also do the trick. I don't know if it is fully compatible, but it seems to work.

@rodrigodagostino
Copy link
Owner

rodrigodagostino commented May 19, 2025

Yes, I think it would make the most sense to close since resolving the current conflicts and the upcoming ones might require more effort than simply working on the migration with a clean slate after the refactoring, but we can keep it open until we reach the migration stage :)

And thank you very much for that last tip! I will keep it in mind :)

@terrakuh
Copy link
Author

Thank you for the library :)

@rodrigodagostino rodrigodagostino force-pushed the main branch 5 times, most recently from 7fed374 to c3a67f7 Compare July 12, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plans to update to Svelte 5?
2 participants