-
Notifications
You must be signed in to change notification settings - Fork 29
Moved messages to trintrin, plus some cleanup #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@davidegorbani @Gianlucamilani I am not sure if these changes will affect your workflow. Let me know if there are issues |
For sure we need to add trintrin in the superbuild before merging this. If this PR works, can yo do a first tag of trintrin to simplify superbuild integration? |
Sure! https://github.com/ami-iit/trintrin/releases/tag/v0.0.1 |
It shouldn't, as we switched to biomechanical-analysis-framework, and we don't currently use this repo. |
Also, I guess we need to update also internal Python repos using |
I did not understand the suggestion 😊 |
Sorry, I wanted to write "update" not "merge". I guess you want to update those repos, and the update is something like:
|
Once this is done, I can remove the source installation of human-dynamics-estimation/.github/workflows/ci.yml Lines 49 to 57 in 6a525a7
|
As now the robotology-superbuild supports this PR, probably we can merge to unblock the following PR? |
Do you believe that the conda package will land in short time (btw, thanks a lot, it is great!)? If yes, w can wait to remove the source installation from CI and be consistent with the other dependencies |
No. There is a critical lack of reviewers on staged-recipes, so the PR could take a long time to be merged. I would proceed with the chain of PRs to avoid being blocked, the only thing that I would block on the |
Ok, then I will edit the CIs to make them happy while waiting for the |
Ah if the problem is making the CI happy, we can also build a first temporary trintrin package to the |
Yeah I was planning to compile trintrin from source where needed, but your plan would be great! Go for me! |
Here you are:
Use I just added them for |
Awesome!
Is it possible also macOS? |
I currently disconnected my macOS to connect the StrixHalo, but I can find a solution. |
I will build for |
Done: |
Removed python dependencies from CI env
Otherwise cmake-package-check was failing
I am having some issues with CI. I added the
while on Mac simply I could not get a runner, so I stopped the workflow. |
In this PR:
HapticGlove
device. Now it is in https://github.com/ami-iit/yarp-device-haptic-gloves/tree/8edbffbedebc907e585852e0a62e7059da8a4f24/SenseGlove