Dev -> Main Merge #572
Open
Dev -> Main Merge #572
+83,468
−65,139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Server_API/app/core/Ingestion_Media_Processing/Video_DL_Ingestion_Lib.py
Fixed
Show fixed
Hide fixed
Server_API/app/core/Ingestion_Media_Processing/Video_DL_Ingestion_Lib.py
Fixed
Show fixed
Hide fixed
tldw_Server_API/app/core/Ingestion_Media_Processing/Video/Video_DL_Ingestion_Lib.py
Dismissed
Show dismissed
Hide dismissed
tldw_Server_API/app/core/Ingestion_Media_Processing/Video/Video_DL_Ingestion_Lib.py
Fixed
Show fixed
Hide fixed
|
|
||
| return schema_info | ||
| except Exception as e: | ||
| return {"error": str(e)} |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 8 days ago
To fix the issue, we will replace the direct exposure of the exception message (str(e)) with a generic error message for the user. The detailed exception information, including the stack trace, will be logged on the server for debugging purposes. This ensures that sensitive information is not exposed to external users while still allowing developers to diagnose issues.
The changes will involve:
- Logging the exception details (e.g., using Python's
loggingmodule). - Returning a generic error message to the user instead of the exception details.
Suggested changeset
1
tldw_Server_API/app/api/v1/endpoints/media.py
| @@ -5406,3 +5406,5 @@ | ||
| except Exception as e: | ||
| return {"error": str(e)} | ||
| import logging | ||
| logging.error("An error occurred in the debug_schema endpoint", exc_info=True) | ||
| return {"error": "An internal error has occurred. Please contact support if the issue persists."} | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
PoC_Version/App_Function_Libraries/Summarization/Local_Summarization_Lib.py
Fixed
Show fixed
Hide fixed
PoC_Version/App_Function_Libraries/Summarization/Local_Summarization_Lib.py
Fixed
Show fixed
Hide fixed
PoC_Version/App_Function_Libraries/Summarization/Local_Summarization_Lib.py
Fixed
Show fixed
Hide fixed
PoC_Version/App_Function_Libraries/Summarization/Local_Summarization_Lib.py
Fixed
Show fixed
Hide fixed
PoC_Version/App_Function_Libraries/Summarization/Local_Summarization_Lib.py
Fixed
Show fixed
Hide fixed
PoC_Version/App_Function_Libraries/Summarization/Local_Summarization_Lib.py
Fixed
Show fixed
Hide fixed
tldw_Server_API/app/core/Ingestion_Media_Processing/PDF/PDF_Processing_Lib.py
Dismissed
Show dismissed
Hide dismissed
tldw_Server_API/app/core/Ingestion_Media_Processing/PDF/PDF_Processing_Lib.py
Dismissed
Show dismissed
Hide dismissed
tldw_Server_API/app/core/Ingestion_Media_Processing/PDF/PDF_Processing_Lib.py
Dismissed
Show dismissed
Hide dismissed
This commit addresses several failing tests in test_prompts_api.py and test_prompts_db_v2.py. Key changes include: - Corrected mocking of settings for token verification tests. - Ensured token format in auth_headers fixture matches expected format. - Switched to using UUIDs for prompt updates in certain tests to avoid potential ID lookup issues. - Added 'deleted' field to prompt search results to fix Pydantic validation. - Fixed logic in keyword creation to correctly raise ConflictError for active duplicates. - Refactored sync log endpoint tests to use FastAPI dependency_overrides for reliable mocking. - Updated database-level prompt creation test to expect ConflictError for duplicates.
…Fully AI Fix multiple test failures in Prompt Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placeholder for when API backend is setup.
Opening this to track build status of dev.