feat: add drizzle sql demo

[jog1t]

No description provided.

[claude]

Claude finished @jog1t's task —— View job

---

PR Review: Drizzle SQL Demo

Reviewing the Drizzle ORM integration in the counter example. Here's my review checklist:

• Analyze Drizzle configuration and setup
• Review database migrations and schema
• Examine integration code changes
• Check code quality and best practices
• Identify potential bugs or issues
• Assess performance considerations
• Review security concerns
• Evaluate test coverage

Review Feedback

✅ Strengths

1. Clean Drizzle Integration: The integration follows RivetKit patterns well, using @rivetkit/db/drizzle and the established actor pattern.

2. Comprehensive Schema: The schema.ts file showcases all SQLite data types and modes, making it an excellent demo for Drizzle capabilities.

3. Proper Migration Setup: The migration structure and migrations.js file follow Drizzle best practices.

⚠️ Issues & Concerns

Code Quality Issues

1. Commented Code in registry.ts:56-60: There's commented-out code that should be removed:

   // c.db.insert(schema.usersTable).values({
   // 	name: "John Doe",
   // 	age: 30,
   // 	email: "john.doe@example.com",
   // });

2. Console.log Usage: Multiple console.log statements (registry.ts:79, 91, 111) should use the project's logger system instead:

   // Instead of console.log("New user created!");
   logger().info("new user created");

Potential Bugs

3. Email Uniqueness Constraint Risk: In addRecords action (registry.ts:72), using Date.now() for email uniqueness could theoretically cause collisions in high-concurrency scenarios. Consider using a more robust unique identifier.

4. Unhandled Promise Rejection: The addRecords action doesn't have proper error handling for database operations. If any insert fails, the entire action could crash the actor.

Performance Concerns

5. Inefficient Batch Inserts: In registry.ts:81-93, posts are inserted sequentially in a Promise.all. This could be optimized with a batch insert:

   // More efficient approach
   const posts = Array.from({ length: 10 }, (_, i) => ({
     title: `My ${i} post`,
     content: "Hello world!",
     userId: returned[0].id,
   }));
   await c.db.insert(schema.postsTable).values(posts);

Missing Elements

6. No README Update: The example doesn't have documentation explaining how to use the new Drizzle functionality.

7. Missing Test Coverage: No tests were added to validate the database operations work correctly.

8. Missing Error Handling: Database operations should handle potential failures and use appropriate RivetKit error classes.

🔒 Security Assessment

• ✅ Good: No hardcoded credentials or sensitive data exposed
• ✅ Good: Proper parameterized queries through Drizzle ORM
• ✅ Good: No SQL injection vulnerabilities

📊 Performance Considerations

• ⚠️ Concern: Sequential insert operations could be batched
• ⚠️ Concern: No database connection pooling considerations mentioned

🧪 Test Coverage

• ❌ Missing: No tests added for database operations
• ❌ Missing: No integration tests for the new addRecords action

📋 Recommendations

1. Remove commented code and replace console.log with logger
2. Add proper error handling for database operations
3. Optimize batch operations for better performance
4. Add integration tests for database functionality
5. Consider adding a README section explaining the Drizzle integration
6. Use more robust unique identifiers instead of timestamp-based emails

🎯 Overall Assessment

This is a solid demonstration of Drizzle ORM integration with RivetKit. The schema design is comprehensive and the integration follows established patterns. However, the code needs cleanup (removing console.log, commented code) and better error handling before merging. The lack of tests is concerning for database integration code.

Recommendation: Request changes for code cleanup and error handling. Consider adding basic integration tests.

[jog1t]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat: add drizzle sql demo #1115 👈 (View in Graphite)
• chore: generate pseudo-random studio token thats url safe #1113 : 1 other dependent PR (#1116 )
• chore: print studio url when starting rivetkit #1112
• fix: modify cors to allow vercel deployments #1110
• chore: cleanup startup logs #1109
• chore: reorder imports and add tsup dependency to sql-loader #1107
• fix(core): use temp files when writing actor state to fs #1106
• feat: inspector v3 #1031
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.