Skip to content

fix: inspector #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: inspector #828

wants to merge 2 commits into from

Conversation

jog1t
Copy link
Collaborator

@jog1t jog1t commented Apr 4, 2025

No description provided.

Copy link
Collaborator Author

jog1t commented Apr 4, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t mentioned this pull request Apr 4, 2025
@jog1t jog1t changed the base branch from 04-03-chore_use_pnpm to graphite-base/828 April 4, 2025 00:25
@jog1t jog1t force-pushed the 04-04-fix_inspector branch from d164d3b to f01ef1d Compare April 4, 2025 00:25
@jog1t jog1t force-pushed the graphite-base/828 branch from 2b807c7 to d572406 Compare April 4, 2025 00:25
@jog1t jog1t changed the base branch from graphite-base/828 to 03-26-feat_add_inspector_to_manager April 4, 2025 00:25
This was referenced Apr 4, 2025
@jog1t jog1t changed the base branch from 03-26-feat_add_inspector_to_manager to graphite-base/828 April 4, 2025 00:27
@jog1t jog1t requested review from NathanFlurry and Copilot and removed request for NathanFlurry April 4, 2025 00:27
@jog1t jog1t self-assigned this Apr 4, 2025
@jog1t jog1t requested a review from NathanFlurry April 4, 2025 00:28
@jog1t jog1t marked this pull request as ready for review April 4, 2025 00:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • examples/chat-room/package.json: Language not supported
  • examples/counter/package.json: Language not supported
Comments suppressed due to low confidence (1)

packages/actor-core-cli/src/commands/dev.tsx:78

  • [nitpick] Consider specifying a termination signal (such as 'SIGTERM') when killing the server process to ensure a graceful shutdown.
server?.kill();

@jog1t jog1t changed the base branch from graphite-base/828 to main April 4, 2025 18:17
@jog1t jog1t closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant