Skip to content

feat: make stream_unsafe_cache_size a session variable #22691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jul 22, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Right now, it is a global configuration variable. This PR makes a session variable.

  1. In general cases, the optimal size of cache varies query by query and its data pattern. It is better if we can tune the setting for each query.
  2. as a temporary workaround for store/cache only single value for first_value and last_value when the input is append-only #22293. Under append-only settings, some aggregation functions only need to store and cache 1 element, but right now we keep 10 elements in cache while storing all the elements. set stream_extreme_cache_size to 1 does not make sense for other queries.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the type/feature Type: New feature. label Jul 22, 2025
@lmatz lmatz added ci/main-cron/run-all and removed type/feature Type: New feature. labels Jul 22, 2025
@github-actions github-actions bot added the type/feature Type: New feature. label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant