Skip to content

feat: show backtrace from iceberg::Error by introducing a newtype #21919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

feat: show backtrace from iceberg::Error by introducing a newtype #21919

merged 1 commit into from
May 20, 2025

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented May 19, 2025

Signed-off-by: xxchan xxchan22f@gmail.com

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan
feat: show backtrace from iceberg::Error by introducing a newtype
2eccc72 
Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan requested a review from a team as a code owner May 19, 2025 13:07
@xxchan xxchan requested a review from cyliu0 May 19, 2025 13:07
@graphite-app graphite-app bot requested a review from a team May 19, 2025 13:07
@xxchan xxchan requested review from BugenZhao and removed request for a team and cyliu0 May 19, 2025 13:07
@xxchan xxchan requested a review from stdrc May 20, 2025 09:44
stdrc
stdrc approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamp

@xxchan xxchan added this pull request to the merge queue May 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2025
@stdrc stdrc added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit cfa40ef May 20, 2025
30 of 31 checks passed
@stdrc stdrc deleted the xxchan/smart-hamster branch May 20, 2025 14:44
@xxchan xxchan mentioned this pull request May 21, 2025
Merged
8 tasks
xxchan added a commit that referenced this pull request May 21, 2025
@xxchan
feat: show backtrace from iceberg::Error by introducing a newtype (#2…
18e943a 
…1919)

Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan mentioned this pull request May 21, 2025
Merged
8 tasks
kwannoel pushed a commit that referenced this pull request May 21, 2025
@xxchan @kwannoel
feat: show backtrace from iceberg::Error by introducing a newtype (#2…
f73457a 
…1919)

Signed-off-by: xxchan <xxchan22f@gmail.com>
BugenZhao
BugenZhao reviewed May 26, 2025
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Some context:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao left review comments

@stdrc stdrc stdrc approved these changes

Assignees
No one assigned
Labels
ci/run-e2e-iceberg-tests type/feature Type: New feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxchan @stdrc @BugenZhao