Skip to content

fix(bin): add missing newline in override mode #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Conversation

dpxcc
Copy link
Contributor

@dpxcc dpxcc commented May 5, 2025

Signed-off-by: Cheng Chen ccqmpux@gmail.com

Without the fix, override mode omits the final newline, resulting in output like:

vscode ➜ /workspaces/pg_mooncake (rust) $ sqllogictest tests/sanity.slt --override
tests/sanity.slt                                             .. [OK] in 11 msvscode ➜ /workspaces/pg_mooncake (rust ✗) $ 

In contrast, non-override mode prints the newline correctly:

vscode ➜ /workspaces/pg_mooncake (rust ✗) $ sqllogictest tests/sanity.slt
tests/sanity.slt                                             .. [OK] in 5 ms
vscode ➜ /workspaces/pg_mooncake (rust ✗) $ 

@stdrc stdrc requested a review from xxchan May 6, 2025 05:33
@xxchan
Copy link
Member

xxchan commented May 6, 2025

Hi, can you add some description?

@xxchan
Copy link
Member

xxchan commented May 6, 2025

Hi, can you add some description about the PR?

@dpxcc
Copy link
Contributor Author

dpxcc commented May 6, 2025

Without the fix, override mode omits the final newline, resulting in output like:

vscode ➜ /workspaces/pg_mooncake (rust) $ sqllogictest tests/sanity.slt --override
tests/sanity.slt                                             .. [OK] in 11 msvscode ➜ /workspaces/pg_mooncake (rust ✗) $ 

In contrast, non-override mode prints the newline correctly:

vscode ➜ /workspaces/pg_mooncake (rust ✗) $ sqllogictest tests/sanity.slt
tests/sanity.slt                                             .. [OK] in 5 ms
vscode ➜ /workspaces/pg_mooncake (rust ✗) $ 

@skyzh
Copy link
Member

skyzh commented May 7, 2025

DCO check failed b/c the commit author is different from the signature. Could you please try again?

git commit --amend -s
git push -f

Thanks :)

Signed-off-by: Cheng Chen <ccqmpux@gmail.com>
@dpxcc
Copy link
Contributor Author

dpxcc commented May 7, 2025

Sorry, it's fixed now. Thanks!

@skyzh skyzh enabled auto-merge (squash) May 7, 2025 06:58
@skyzh skyzh merged commit 3a3ddc0 into risinglightdb:main May 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants