Simplify PMP control code by removing pmpMatchEntry

[Timmmm]

I think this extra function was unnecessary and just made the code harder to follow.

[arichardson]

Since there is only one call the extra indirection and new type don't add any value. easier to understand now.

[pmundkur]

One advantage of the current code is pmpMatchEntry is a pure function for which it is easier to write SMT property tests.

[arichardson]

CI is not happy with this:

Type error:
riscv_pmp_control.sail:108.11-74:
108 |        if pmpCheckRWX(cfg, acc) | (priv == Machine & not(pmpLocked(cfg)))
    |           ^-------------------------------------------------------------^ checking function argument has type Pmpcfg_ent
    | Identifier cfg is unbound

[Timmmm]

CI is not happy with this:

Oops, fixed.

One advantage of the current code is pmpMatchEntry is a pure function for which it is easier to write SMT property tests.

That is true. Not sure I have a strong opinion on that.

[github-actions]

Test Results

400 tests  ±0   400 ✅ ±0   1m 25s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 20e63d9. ± Comparison against base commit fd99207.

[pmundkur]

As discussed in today's meeting, property tests don't have to be pure. We can prioritize for readability here.