os-boot/opensbi: add opensbi. #966
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The number should change. |
Arielfoever
force-pushed
the
pr/opensbi
branch
3 times, most recently
from
defa20c to
2b0a675
Compare
arichardson
reviewed
May 22, 2025
Signed-off-by: Ariel Xiong <ArielHeleneto@outlook.com>
jrtc27
reviewed
May 23, 2025
| @@ -14,10 +17,16 @@ | |||
| reg = <0>; | |||
| status = "okay"; | |||
| compatible = "riscv"; | |||
| riscv,isa = "rv64imac"; | |||
| riscv,isa-base = "rv64i"; | |||
There was a problem hiding this comment.
This can't boot FreeBSD, it currently only recognises riscv,isa.
There was a problem hiding this comment.
Also, why is the FDT within opensbi/?
There was a problem hiding this comment.
This can't boot FreeBSD, it currently only recognises riscv,isa.
I just test openSBI here, let FreeBSD to another pr(
jrtc27
reviewed
May 23, 2025
| @@ -5,6 +5,9 @@ | |||
| #size-cells = <2>; | |||
| compatible = "ucbbar,spike-bare-dev"; | |||
| model = "ucbbar,spike-bare"; | |||
| chosen { | |||
| bootargs = "console=hvc0 earlycon=sbi"; | |||
There was a problem hiding this comment.
These are Linux-specific, do they really belong here?
There was a problem hiding this comment.
That doesn't mater I think(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.