Test multiple versions of CMake in CI #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordancarlin
force-pushed
the
cmake_versions_in_ci
branch
2 times, most recently
from
0506d5d to
d78d14e
Compare
Timmmm
reviewed
May 15, 2025
jordancarlin
force-pushed
the
cmake_versions_in_ci
branch
2 times, most recently
from
8c79c05 to
eca3c49
Compare
Timmmm
approved these changes
May 16, 2025
jordancarlin
force-pushed
the
cmake_versions_in_ci
branch
from
eca3c49 to
ed4ce81
Compare
arichardson
approved these changes
May 26, 2025
|
Well, I'm very confused, but I just tested it again and 3.20 worked. There was a library version issue before (don't remember what), but when I tried to reproduce it, everything worked fine. Reverting to 3.20 as the minimum version. |
jordancarlin
force-pushed
the
cmake_versions_in_ci
branch
from
ed4ce81 to
594a73d
Compare
jordancarlin
force-pushed
the
cmake_versions_in_ci
branch
from
594a73d to
53dde2f
Compare
Timmmm
approved these changes
May 27, 2025
arichardson
approved these changes
May 27, 2025
Timmmm
added
the
will be merged
tobiasgrosser
pushed a commit
to opencompl/sail-riscv
that referenced
this pull request
Jun 1, 2025
Test both our oldest supported CMake version (3.20) and the latest CMake release in CI when building the model. Fixes riscv#948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test both our oldest supported CMake version (3.20) and the latest CMake release in CI when building the model.
Fixes #948