Skip to content

FIXES ISSUE #827: Improve Zclsd Constraint Visibility Outside of operation() Function #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omsuneri
Copy link

this PR resolves issue #827 by moving the Zclsd constraint from the operation() function to the instruction-level definedBy field in c.ld.yaml, improving visibility for downstream tools such as disassemblers that do not evaluate operation() logic

why not used the suggested schema format?

definedBy:
  RV32:
    name: Zclsd
  RV64:
    anyOf:
      - name: C
      - name: Zca

This format is not valid under the current inst_schema.json constraints. Specifically, definedBy only supports string, anyOf, allOf, oneOf, or not constructs based on requires_entry, and does not allow architecture-specific keys like RV32 or RV64 So this approach had to be adapted within the allowed schema

Signed-off-by: Om Santosh Suneri <142336291+omsuneri@users.noreply.github.com>
@omsuneri
Copy link
Author

@ThinkOpenly please review the changes and if you want me to follow the suggested format thats in your comment please ask me to do i ll try to update the schema_defs.json.

@dhower-qc
Copy link
Collaborator

Thanks! This is a great suggestion. So good, in fact, that it is being enabled by #891 😄.

Once 891 is in main, we can make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants