-
Notifications
You must be signed in to change notification settings - Fork 44
feat(schema): Add schema for I-x-x subtype #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(schema): Add schema for I-x-x subtype #892
Conversation
In (riscv-software-src#686), a new instruction schema was created for types/subtypes. This commit add the schema for the I-type. It is also part of effort in (riscv-software-src#655). Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Reference to the Subtype discussion in the #655 (comment). Some issue with the pr, it was not supposed to add the first three pr. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
=======================================
Coverage 43.30% 43.30%
=======================================
Files 10 10
Lines 4787 4787
Branches 1298 1298
=======================================
Hits 2073 2073
Misses 2714 2714
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the nit about name, this looks good to me.
83217a9
to
36e285d
Compare
36e285d
to
f055c24
Compare
In (riscv-software-src#686), a new instruction schema was created for types/subtypes. This commit add the schema for the I-x-x subtype. This commit also add schema for immediate variable and variable type. It is also part of effort in (riscv-software-src#655). Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
f055c24
to
300a9bb
Compare
In (#686), a new instruction schema was created
for types/subtypes. This commit add the schema
for the I-x-x subtype. This commit also add schema
for immediate variable and variable type. It is also
part of effort in (#655).