Skip to content

feat(schema): Add schema for I-x-x subtype #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Unique-Usman
Copy link
Contributor

In (#686), a new instruction schema was created
for types/subtypes. This commit add the schema
for the I-x-x subtype. This commit also add schema
for immediate variable and variable type. It is also
part of effort in (#655).

In (riscv-software-src#686), a new instruction schema was created
for types/subtypes. This commit add the schema
for the I-type. It is also part of effort in (riscv-software-src#655).

Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
@Unique-Usman
Copy link
Contributor Author

Reference to the Subtype discussion in the #655 (comment).

Some issue with the pr, it was not supposed to add the first three pr.

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.30%. Comparing base (1ff5df5) to head (300a9bb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   43.30%   43.30%           
=======================================
  Files          10       10           
  Lines        4787     4787           
  Branches     1298     1298           
=======================================
  Hits         2073     2073           
  Misses       2714     2714           
Flag Coverage Δ
idlc 43.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@dhower-qc dhower-qc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nit about name, this looks good to me.

In (riscv-software-src#686), a new instruction schema was created
for types/subtypes. This commit add the schema
for the I-x-x subtype. This commit also add schema
for immediate variable and variable type. It is also
part of effort in (riscv-software-src#655).

Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants