Skip to content

refactor: move mock data into arch_overlay #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dhower-qc
Copy link
Collaborator

This also required some restructuring around Ruby portfolios, since we
have to start with ConfiguredArchitecture to pull in overlays.

@dhower-qc
Copy link
Collaborator Author

dhower-qc commented May 9, 2025

@henrikg-qc

@dhower-qc dhower-qc force-pushed the mockmove branch 2 times, most recently from ad8139b to 6d8a5e6 Compare May 9, 2025 17:21
Copy link
Collaborator

@james-ball-qualcomm james-ball-qualcomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some fundamental changes you've made here that I'm not clear why/what is happening now. If you want me to help maintain this code going forward, can you please setup a meeting with me to go over your changes together?

Copy link
Collaborator

@james-ball-qualcomm james-ball-qualcomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've thought about this some more and realize this isn't what I want at all. Instead of moving the mock things into an overlay, I want a mock arch directory and then move the mock things into that. Then have the tools that operate on the arch directory be able to point to the real arch directory or the mock arch directory. I know you've hard-coded the path to the architecture directory in many places so those would have to be changed to accept some-kind of global variable containing the path to use (say either "arch" or "mock_arch"). We'll need the mock arch directory in order to make unit-level regression tests that examine the generated output (e.g., adoc files) to determine pass/fail.

@dhower-qc
Copy link
Collaborator Author

Why is that better than this solution? Either way, you can use the tools to inspect only Mock data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants