Skip to content

feat: add Zfinx, Zdinx, Zhinxmin extensions, modify check_f_ok for them #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add Zfinx, Zdinx, Zhinxmin extensions, modify check_f_ok for them #711

wants to merge 2 commits into from
+166 −14

Conversation

dhower-qc
Copy link
Collaborator

  • Adds missing inx extension skeletons.
  • Updates the check_f_ok IDL function to look at mstateen0.FCSR instead of mstatus.FS when an inx extension is implemented

@dhower-qc
Copy link
Collaborator Author

not done; depends on #592

@dhower-qc dhower-qc mentioned this pull request Apr 30, 2025
Merged
@dhower-qc dhower-qc force-pushed the check_f_ok branch 2 times, most recently from 9810e9a to 281f334 Compare April 30, 2025 21:58
jordancarlin
jordancarlin suggested changes Apr 30, 2025
View reviewed changes
jordancarlin
jordancarlin reviewed Apr 30, 2025
View reviewed changes
ThinkOpenly
ThinkOpenly reviewed May 1, 2025
View reviewed changes
@dhower-qc
Copy link
Collaborator Author

@jordancarlin, thanks for the review. I think I've fixed it all.

@dhower-qc dhower-qc mentioned this pull request May 1, 2025
Merged
@dhower-qc
feat: add Z{f,d,h}inx{min} extensions, modify check_f_ok for them
00309f2 
* Adds missing *inx* extension skeletons.
* Updates the check_f_ok IDL function to look at mstateen0.FCSR instead of
  mstatus.FS when an *inx* extension is implemented
@dhower-qc dhower-qc changed the base branch from main to descschema May 1, 2025 14:17
ThinkOpenly
ThinkOpenly reviewed May 1, 2025
View reviewed changes
Base automatically changed from descschema to main May 1, 2025 14:43
@jordancarlin jordancarlin mentioned this pull request May 5, 2025
Merged
@neverlandiz
Copy link
Contributor

Since PR #592 and PR #711 depend on each other, the block of code below will be commented out in PR #592 for hstateen0.yaml, mstateen0.yaml, and sstateen0.yaml. Please remember to uncomment it before merging PR #711, thanks!

definedBy:
   anyOf: [Zfinx, Zdinx]

@ThinkOpenly ThinkOpenly changed the title feat: add Z{f,d,h}inx{min} extensions, modify check_f_ok for them feat: add Zfinx, Zdinx, Zhinxmin extensions, modify check_f_ok for them May 8, 2025
ThinkOpenly
ThinkOpenly reviewed May 21, 2025
View reviewed changes
arch/ext/Zfinx.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameterization for mstateen0.FCSR probably needs to be added here, similar to what's been done for HSTATEEN_ENVCFG_TYPE that's coming in #592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThinkOpenly ThinkOpenly ThinkOpenly left review comments

@jordancarlin jordancarlin jordancarlin approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhower-qc @neverlandiz @ThinkOpenly @jordancarlin