feat: move cache block size initialization to constructor #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
reviewed
May 15, 2025
Previously cache block size had to be initialized via special set_chache_blocksz setter function and was uninitialized if you didn't call it. In this commit I move initialization of the block size to the mmu_t's constructor. The configuration of this member goes through cfg_t struct.
arrv-sc
force-pushed
the
arrv-sc/init-blocksz
branch
from
1b0b498 to
b346571
Compare
|
I agree. Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously cache block size had to be initialized via special set_chache_blocksz setter function and was uninitialized if you didn't call it. This caused us some issues when we forgot to call a setter function and everything worked fine until first Zicbom instruction where spike went into an infinite loop (on uninitialized value). This commit was made as a measure to prevent similar issues in the future. In this commit I move initialization of the block size to the mmu_t's constructor. The value of this member goes through cfg_t struct. This way the value will always be initialized without loosing ability to be reset via mentioned setter function if one needs to do so.