Skip to content

Commit 9c5a20f

Browse files
committed
Work if tcontrol doesn't exist.
1 parent cb78f09 commit 9c5a20f

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

riscv/insns/mret.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ if (prev_virt && prev_prv == PRV_U)
2020
STATE.vsstatus->write(STATE.vsstatus->read() & ~SSTATUS_SDT);
2121
STATE.mstatus->write(s);
2222
if (STATE.mstatush) STATE.mstatush->write(s >> 32); // log mstatush change
23-
STATE.tcontrol->write((STATE.tcontrol->read() & CSR_TCONTROL_MPTE) ? (CSR_TCONTROL_MPTE | CSR_TCONTROL_MTE) : 0);
23+
if (STATE.tcontrol) STATE.tcontrol->write((STATE.tcontrol->read() & CSR_TCONTROL_MPTE) ? (CSR_TCONTROL_MPTE | CSR_TCONTROL_MTE) : 0);
2424
p->set_privilege(prev_prv, prev_virt);

riscv/processor.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ void processor_t::take_trap(trap_t& t, reg_t epc)
535535
state.elp = elp_t::NO_LP_EXPECTED;
536536
state.mstatus->write(s);
537537
if (state.mstatush) state.mstatush->write(s >> 32); // log mstatush change
538-
state.tcontrol->write((state.tcontrol->read() & CSR_TCONTROL_MTE) ? CSR_TCONTROL_MPTE : 0);
538+
if (state.tcontrol) state.tcontrol->write((state.tcontrol->read() & CSR_TCONTROL_MTE) ? CSR_TCONTROL_MPTE : 0);
539539
set_privilege(PRV_M, false);
540540
}
541541
}

riscv/triggers.cc

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,18 @@ void trigger_t::tdata3_write(processor_t * const proc, const reg_t val) noexcept
5555
sselect = (sselect_t)((proc->extension_enabled_const('S') && get_field(val, CSR_TEXTRA_SSELECT(xlen)) <= SSELECT_MAXVAL) ? get_field(val, CSR_TEXTRA_SSELECT(xlen)) : SSELECT_IGNORE);
5656
}
5757

58+
static reg_t tcontrol_value(const state_t * state) {
59+
if (state->tcontrol)
60+
return state->tcontrol->read();
61+
else
62+
return 0;
63+
}
64+
5865
bool trigger_t::common_match(processor_t * const proc, bool use_prev_prv) const noexcept {
5966
auto state = proc->get_state();
6067
auto prv = use_prev_prv ? state->prev_prv : state->prv;
6168
auto v = use_prev_prv ? state->prev_v : state->v;
62-
auto m_enabled = get_action() != 0 || (state->tcontrol->read() & CSR_TCONTROL_MTE);
69+
auto m_enabled = get_action() != 0 || (tcontrol_value(state) & CSR_TCONTROL_MTE);
6370
return (prv < PRV_M || m_enabled) && mode_match(prv, v) && textra_match(proc);
6471
}
6572

0 commit comments

Comments
 (0)