Skip to content

fix: improve ISA regex validation and add comprehensive test suite #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

zouguangxian
Copy link

Description

  • Fix ISA regex pattern to properly handle sub-extensions like 'RV32I_Zicsr'
  • Add comprehensive pytest-based test suite with 100% coverage
  • Create developer-friendly Makefile with self-documenting help
  • Add TESTING.md with quickstart and usage instructions
  • Include test dependencies (pytest, pytest-cov) and configuration
  • Add run_tests.py alternative test runner
  • Improve regex to handle extension combinations correctly

Related Issues

  • isa_regex.match('RV32I_Zicsr') will return None.

Update to/for Ratified/Unratified Extensions

  • Ratified
  • Unratified

List Extensions

List the extensions that your PR affects. In case of unratified extensions, please provide a link to the spec draft that was referred to make this PR.

Mandatory Checklist:

  • Make sure you have updated the versions in setup.cfg and riscv_config/__init__.py. Refer to CONTRIBUTING.rst file for further information.
  • Make sure to have created a suitable entry in the CHANGELOG.md.

- Fix ISA regex pattern to properly handle sub-extensions like 'RV32I_Zicsr'
- Add comprehensive pytest-based test suite with 100% coverage
- Create developer-friendly Makefile with self-documenting help
- Add TESTING.md with quickstart and usage instructions
- Include test dependencies (pytest, pytest-cov) and configuration
- Add run_tests.py alternative test runner
- Improve regex to handle extension combinations correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant