Updates 2.0.4 issue 93 #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| defined, indicated by the value 0. | ||
| |*qual_status*| 2| 00 (no_change): No change to filter qualification + | ||
| 01 (ended_rep): Qualification ended, preceding *te_inst* sent explicitly to indicate last qualification | ||
| 01 (ended_rep): Qualification ended, preceding *te_inst* sent explicitly to indicate final qualification |
There was a problem hiding this comment.
In reviewing where this text exists in the existing PDF, I notice that it doesn't properly show any of the 2-bit values before the parentheses. That should be fixed so people know what the encodings are.
There was a problem hiding this comment.
That was a failure of the semi-automatic LaTeX to adoc conversion process that got missed at the time. I had fixed many of these, but your comment prompted me to do a thorough review and I found a few more, which I have now fixed and included in the PR.
ved-rivos
approved these changes
Nov 12, 2024
Co-authored-by: Paul Donahue <48959409+pdonahue-ventana@users.noreply.github.com> Signed-off-by: IainCRobertson <48293834+IainCRobertson@users.noreply.github.com>
Co-authored-by: Paul Donahue <48959409+pdonahue-ventana@users.noreply.github.com> Signed-off-by: IainCRobertson <48293834+IainCRobertson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to address Issue 93. Need confirmation from Paul Donahue (who raised that issue) that this addresses it