target/riscv/riscv.c: support auto-selection of software breakpoint size #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aap-sc
requested review from
JanMatCodasip and
en-sc
and removed request for
JanMatCodasip
AlexandraKulyatskaya
force-pushed
the
a.kulyatskaya/auto-selection-bp-size
branch
2 times, most recently
from
427b9ee to
3cf367c
Compare
Add auto-selection of breakpoint size for RISC-V targets. The new length depends on C extension. If the C extension is used, the auto-selected length is 2 bytes. Otherwise, the default length is 4 bytes. Change-Id: Ie3473514beace15b76714aa6d5441122cd3262aa Signed-off-by: Kulyatskaya Alexandra <a.kulyatskaya@syntacore.com>
AlexandraKulyatskaya
force-pushed
the
a.kulyatskaya/auto-selection-bp-size
branch
from
3cf367c to
e307df1
Compare
|
@AlexandraKulyatskaya, I'd suggest avoiding modifying the length of the breakpoint. Consider instead introducing a new Please, note that in general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auto-selection of breakpoint size for RISC-V targets. The new length depends on C extension. If the C extension is used, the auto-selected length is 2 bytes. Otherwise, the default length is 4 bytes.
Change-Id: Ie3473514beace15b76714aa6d5441122cd3262aa