-
Notifications
You must be signed in to change notification settings - Fork 8
WIP: Support of different timezones on client & server #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
joha78
wants to merge
2
commits into
rico-projects:master
Choose a base branch
from
joha78:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
84 changes: 84 additions & 0 deletions
84
...g-common/src/main/java/dev/rico/internal/remoting/converters/InstantConverterFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright 2018-2019 Karakun AG. | ||
| * Copyright 2015-2016 Canoo Engineering AG. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package dev.rico.internal.remoting.converters; | ||
|
|
||
|
|
||
| import dev.rico.remoting.converter.Converter; | ||
| import dev.rico.remoting.converter.ValueConverterException; | ||
|
|
||
| import java.time.Instant; | ||
| import java.time.format.DateTimeFormatter; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Created by hendrikebbers on 25.10.16. | ||
| * Adopted by Jörg Hälker on 29.01.18. | ||
| */ | ||
| public class InstantConverterFactory extends AbstractConverterFactory { | ||
|
|
||
| @SuppressWarnings("rawtypes") | ||
| private final static Converter CONVERTER = new InstantConverter(); | ||
|
|
||
| @Override | ||
| public boolean supportsType(final Class<?> cls) { | ||
| return Instant.class.isAssignableFrom(cls); | ||
| } | ||
|
|
||
| @Override | ||
| public List<Class> getSupportedTypes() { | ||
| return Collections.singletonList(Instant.class); | ||
| } | ||
|
|
||
| @Override | ||
| public int getTypeIdentifier() { | ||
| return 1000; | ||
| } | ||
|
|
||
| @Override | ||
| public Converter getConverterForType(final Class<?> cls) { | ||
| return CONVERTER; | ||
| } | ||
|
|
||
| private static class InstantConverter extends AbstractStringConverter<Instant> { | ||
|
|
||
| @Override | ||
| public Instant convertFromRemoting(final String value) throws ValueConverterException { | ||
| if (value == null) { | ||
| return null; | ||
| } | ||
| try { | ||
| return Instant.from(DateTimeFormatter.ISO_INSTANT.parse(value)); | ||
| } catch (Exception e) { | ||
| throw new ValueConverterException("Can not convert to Instant", e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public String convertToRemoting(final Instant value) throws ValueConverterException { | ||
| if (value == null) { | ||
| return null; | ||
| } | ||
| try { | ||
| return value.toString(); | ||
| } catch (Exception e) { | ||
| throw new ValueConverterException("Can not convert from Instant", e); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
...common/src/main/java/dev/rico/internal/remoting/converters/LocalTimeConverterFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright 2018-2019 Karakun AG. | ||
| * Copyright 2015-2016 Canoo Engineering AG. | ||
hendrikebbers marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package dev.rico.internal.remoting.converters; | ||
|
|
||
|
|
||
| import dev.rico.remoting.converter.Converter; | ||
| import dev.rico.remoting.converter.ValueConverterException; | ||
|
|
||
| import java.time.LocalTime; | ||
| import java.time.format.DateTimeFormatter; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Created by hendrikebbers on 25.10.16. | ||
hendrikebbers marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * Adopted by Jörg Hälker on 29.01.18. | ||
| */ | ||
| public class LocalTimeConverterFactory extends AbstractConverterFactory { | ||
|
|
||
| @SuppressWarnings("rawtypes") | ||
| private final static Converter CONVERTER = new LocalTimeConverter(); | ||
|
|
||
| @Override | ||
| public boolean supportsType(final Class<?> cls) { | ||
| return LocalTime.class.isAssignableFrom(cls); | ||
| } | ||
|
|
||
| @Override | ||
| public List<Class> getSupportedTypes() { | ||
| return Collections.singletonList(LocalTime.class); | ||
| } | ||
|
|
||
| @Override | ||
| public int getTypeIdentifier() { | ||
| return 1200; | ||
| } | ||
|
|
||
| @Override | ||
| public Converter getConverterForType(final Class<?> cls) { | ||
| return CONVERTER; | ||
| } | ||
|
|
||
| private static class LocalTimeConverter extends AbstractStringConverter<LocalTime> { | ||
|
|
||
| @Override | ||
| public LocalTime convertFromRemoting(final String value) throws ValueConverterException { | ||
| if (value == null) { | ||
| return null; | ||
| } | ||
| try { | ||
| return LocalTime.from(DateTimeFormatter.ISO_TIME.parse(value)); | ||
| } catch (Exception e) { | ||
| throw new ValueConverterException("Can not convert to LocalTime", e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public String convertToRemoting(final LocalTime value) throws ValueConverterException { | ||
| if (value == null) { | ||
| return null; | ||
| } | ||
| try { | ||
| return value.toString(); | ||
| } catch (Exception e) { | ||
| throw new ValueConverterException("Can not convert from LocalTime", e); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.