Add metrics for revocation information provided via Certificate Revocation Lists #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA/B Forum Ballot SC-063 v4 (details) makes OCSP optional in favor of CRLs, which have regained traction in the past few years. Let's Encrypt has also announced that they will be phasing out OCSP in favor of CRL. As such, usage of CRLs as a revocation declaration mechanism is expected to increase. To handle this, this PR introduces support for retrieving and exposing revocation information for certificates using Certificate Revocation Lists.
In the files I've modified I also noticed that the deprecated
io/ioutilis still in use, so I took the liberty of replacing calls toioutilfunctions with their modern counterpart. This is admitedly unrelated to the CRL support, so I can remove 4dae54f, or if desired I can also replaceioutilcalls in the rest of the files in the project.