Implement for App Alert #5
Conversation
1. move initialState to store and inject it when store creating 2. separate reducers
ungitConfig: for ungit configuraion userConfig: for user configuration version: for the versions of ungit itself and git common: some common actionCreators bootstrap: for initialization, aggregrate some actionCreators and use it when app init
|
Currently, we can get some basic data via this PR
|
|
@CYBAI please have a look on it, this PR have following tasks done, and you can merge it due to it will be easy and helpful for the development of your part.
I'm going to open another two PR One is for implement the components( The other is for the testing. |
src-react/actions/ungit-config.js
Outdated
| }; | ||
| }; | ||
|
|
||
| function receiveUgitConfig(ungitConfig) { |
There was a problem hiding this comment.
I think it's typo in the function name?
receiveUgitConfig => receiveUngitConfig
src-react/containers/path.js
Outdated
| import { connect } from 'react-redux' | ||
|
|
||
| import AlerArea from 'components/alert-area'; |
src-react/actions/bootstrap.js
Outdated
|
|
||
| export function bootstrap() { | ||
| return dispatch => { | ||
| dispatch(pending(4)); |
There was a problem hiding this comment.
Just want to make my understanding much clearer.
I think the usage of pending is to know how many APIs don't finish yet.
If my understanding is correct, according to this bootstrap action, there're three fetch action, why do you use 4 here?
There was a problem hiding this comment.
Due to ungitconfig action will also fetch userconfig, but after I check the code, there's a condition to decide if fetching userconfig or not, so I think I need to move a pending call into ungitconfig
It's fixed
Commit some useful and important part for reviewing.
Target: implement the alert area on
component/app/app.js.Todo: