Use sass for styles #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scss files under `styles` folder are compiled from `public/less`.
AllenFang
reviewed
May 21, 2017
src-react/containers/path.js
Outdated
| @@ -1,6 +1,8 @@ | |||
| import React, { Component } from 'react'; | |||
| import { connect } from 'react-redux' | |||
|
|
|||
| import "../styles/styles.scss"; | |||
There was a problem hiding this comment.
it's wired... why eslint allow double quotes
There was a problem hiding this comment.
Oh... I didn't notice that.
Let me fix it.
BTW, seems that the react-app eslint rules allow both no-semi and semi.
(Check line 2)
There was a problem hiding this comment.
Updated for single quotes; I also add the webpack alias for styles.
Besides, let's fix the eslint issue in another PR?
There was a problem hiding this comment.
Fix eslint on another PR,
and I recommend use resolve.modulesDirectories to solve all the problem about require() relative path hell.
AllenFang
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scss files under
stylesfolder are compiled frompublic/less.