fix(ui plugins create): only include plugins owned by current tenant during named lookup #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where the "smart"
c8y ui plugins createcommand would check if the given plugin already exists or not, however when run against themanagementtenant, if subtenants already had a plugin with the same name, it would result in the incorrect plugin being found.Now the ui plugin named lookup (only during the
c8y ui plugins createcommand) will only look for plugins owned by the current tenant.Note The bug was fixed in the underlying go-c8y library in reubenmiller/go-c8y#73