-
Notifications
You must be signed in to change notification settings - Fork 89
tracing-endpoint: add support for OTLP+HTTP #3580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02de961
to
1a6ade8
Compare
jackkleeman
reviewed
Jul 24, 2025
jackkleeman
reviewed
Jul 24, 2025
jackkleeman
reviewed
Jul 24, 2025
268e37a
to
1713737
Compare
jackkleeman
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks
AhmedSoliman
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I trust that you have tested this before merging.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OTLP+HTTP support to the tracing-endpoint and/or tracing-services-endpoint OTel trace data exporter.
Until now, these endpoints configured an OTel trace data exporter that was hard-coded to use the gRPC transport. If you're familiar with OTel conventions this would correspond to what a collector can accept on typical port 4317.
With this change users can specify transport (and encoding) via the tracing-endpoint's scheme. For example to emit OTLP/HTTP you would set tracing-endpoint to e.g.
otlp+http://my.collector.biz:4318/v1/traces
-- note the/v1/traces
path.