Check that selected node sets fulfill the desired replication properties #3571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
issues/3564
branch
from
7fb602b to
d400b80
Compare
AhmedSoliman
approved these changes
Jul 24, 2025
This commit adds a check that verifies that a selected node set fulfills the desired replication property before reconfiguring a log. This ensures that we don't end up in a situation where a log becomes unwritable because there is no chance to find a write quorum in the node set. This fixes restatedev#3564.
tillrohrmann
force-pushed
the
issues/3564
branch
from
d400b80 to
feeaf7f
Compare
|
Merged via 221af91 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check that verifies that a selected node set fulfills the desired replication property before reconfiguring a log. This ensures that we don't end up in a situation where a log becomes unwritable because there is no chance to find a write quorum in the node set.
This fixes #3564.