Schema registry changes #3550
Open
Schema registry changes #3550
+2,555
−2,394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally bumping the version of Restate here to |
slinkydeveloper
force-pushed
the
issues/3303-part-2
branch
from
1a40491 to
644c9f7
Compare
slinkydeveloper
changed the title
slinkydeveloper
force-pushed
the
issues/3303-part-2
branch
from
644c9f7 to
23415a8
Compare
| use crate::{Version, Versioned, identifiers}; | ||
| use arc_swap::ArcSwapOption; | ||
| use restate_serde_util::MapAsVecItem; | ||
| use serde_json::Value; |
There was a problem hiding this comment.
nit: I'd appreciate if imports are organized according to our convention.
There was a problem hiding this comment.
As said in other PRs, I'll be happy to do that with a tool that automates it.
slinkydeveloper
force-pushed
the
issues/3303-part-2
branch
from
1d32638 to
b0ec13f
Compare
This commit contains the changes described in restatedev#3303 * metadata contains the "implementation" of the schema registry, and the serializable data structure `Schema`. * `metadata/mod.rs` contains the definition of `Schema` and the implementation of the various schema registry APIs. All the fields are private, and access should be available only through schema registry APIs or `SchemaUpdater`. * `Schema` now uses the new data types from the old `v2.rs` file. On deserialization, we infer the "active service revisions" index (the logic for that is within `serde_hacks`). * `v2.rs` conversions was moved to `metadata/serde_hacks.rs`, the new data model is directly in `metadata/mod.rs`. Inside it, I moved the old data types *Schemas, which should not be used anymore. * `SchemaUpdater` was moved inside `metadata`, and deals with the new `Schema` data structure. The behavior remains untouched. Everything else is more or less copying stuff around and renaming.
We should merge this for Restate 1.5
slinkydeveloper
force-pushed
the
issues/3303-part-2
branch
from
b0ec13f to
c36a867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3303