metadata-providers: objstore: add telemetry #3545
Merged
+469
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
crates/metadata-providers/src/objstore/in_memory_version_repository.rs
Outdated
Show resolved
Hide resolved
AhmedSoliman
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
Looks great. Thanks @peterbourgon for improving the object store metadata provider's observability.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds debug- and trace-level telemetry to the objstore (S3) metadata provider. It also adds a bunch of tests at the uppermost (glue) layer, as well as an in-memory VersionRepository, in support of those tests.