[ReplicatedLoglet] Remote append #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
force-pushed
the
pr2003
branch
5 times, most recently
from
1b1ab5a to
cdf8c26
Compare
muhamadazmy
commented
Oct 1, 2024
muhamadazmy
commented
Oct 1, 2024
muhamadazmy
force-pushed
the
pr2003
branch
3 times, most recently
from
28f7212 to
edf697a
Compare
muhamadazmy
force-pushed
the
pr2003
branch
2 times, most recently
from
dbc714a to
32c0d35
Compare
muhamadazmy
commented
Oct 2, 2024
AhmedSoliman
reviewed
Oct 2, 2024
muhamadazmy
force-pushed
the
pr2003
branch
4 times, most recently
from
93db90e to
279bed6
Compare
muhamadazmy
commented
Oct 2, 2024
muhamadazmy
force-pushed
the
pr2003
branch
2 times, most recently
from
eb00dba to
eac9368
Compare
pcholakov
reviewed
Oct 2, 2024
tillrohrmann
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Thanks a lot for creating the RemoteSequencer @muhamadazmy. The changes look good to me. I had a few minor comments and one question about the handling of the inflight request when a connection gets closed.
crates/bifrost/src/providers/replicated_loglet/remote_sequencer.rs
Outdated
Show resolved
Hide resolved
crates/bifrost/src/providers/replicated_loglet/remote_sequencer.rs
Outdated
Show resolved
Hide resolved
crates/bifrost/src/providers/replicated_loglet/remote_sequencer.rs
Outdated
Show resolved
Hide resolved
crates/bifrost/src/providers/replicated_loglet/remote_sequencer.rs
Outdated
Show resolved
Hide resolved
crates/bifrost/src/providers/replicated_loglet/remote_sequencer.rs
Outdated
Show resolved
Hide resolved
crates/bifrost/src/providers/replicated_loglet/remote_sequencer.rs
Outdated
Show resolved
Hide resolved
crates/bifrost/src/providers/replicated_loglet/remote_sequencer.rs
Outdated
Show resolved
Hide resolved
crates/bifrost/src/providers/replicated_loglet/remote_sequencer.rs
Outdated
Show resolved
Hide resolved
muhamadazmy
force-pushed
the
pr2003
branch
2 times, most recently
from
835ce9a to
62db52f
Compare
muhamadazmy
commented
Oct 3, 2024
muhamadazmy
force-pushed
the
pr2003
branch
6 times, most recently
from
ad804f3 to
845d464
Compare
Summary: Implements a remote loglet append calls to leader sequencer
tillrohrmann
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Thanks for addressing my comments @muhamadazmy. The changes look good to me :-)
Comment on lines
+377
to
+378
| // For now this should not be a problem since they can (possibly) retry | ||
| // to do the write again later. |
There was a problem hiding this comment.
Which means that we effectively produce in at least once manner to Bifrost, right?
There was a problem hiding this comment.
@tillrohrmann That is correct. Application layer is responsible for running deup. Bifrost guarantees that committed records have accomplished a write quorum. But failed writes can still show up in the logs. For example during seal. Hence application layer must take care of duplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ReplicatedLoglet] Remote append
Summary:
Implements a remote loglet append calls to leader sequencer
Stack created with Sapling. Best reviewed with ReviewStack.