Skip to content

Rename all remaining bsconfig.json to rescript.json #7697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jul 22, 2025

Rename all remaining bsconfig.json to rescript.json, other than tests/build_tests/warn_legacy_config/bsconfig.json where it's needed for the test.

Copy link

pkg-pr-new bot commented Jul 22, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7697

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7697

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7697

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7697

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7697

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7697

commit: 7bcddd7

@cknitt cknitt requested review from Bushuo and fhammerschmidt July 22, 2025 14:33
@Bushuo
Copy link
Collaborator

Bushuo commented Jul 22, 2025

What about tests/build_tests/transitive_dependency/node_modules/b/bsconfig.json

@cknitt
Copy link
Member Author

cknitt commented Jul 22, 2025

What about tests/build_tests/transitive_dependency/node_modules/b/bsconfig.json

These somehow those managed to stay under the radar as they are in a node_modules folder. Thanks!

@cknitt cknitt merged commit 663bfd0 into master Jul 22, 2025
27 checks passed
@cknitt cknitt deleted the rescript-json branch July 22, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants