Don't ignore Stdlib_* files when generating docstring tests #7694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Jul 22, 2025
| @@ -12,22 +12,22 @@ let nodeVersion = | |||
|
|
|||
| let ignoreRuntimeTests = [ | |||
| ( | |||
| // Ignore some tests require Node.js v20+ | |||
| // Ignore tests that require Node.js v20+ | |||
There was a problem hiding this comment.
I wonder if we still need this?
Our .nvm is 22 now right?
There was a problem hiding this comment.
Would be great to get rid of if we can.
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocTestwas not generating docstring tests for Stdlib modules as it was ignoring all files starting withStdlib_.I discovered this issue while looking into why I couldn't manage to get doctests for a new binding I was writing to fail.
Also, tests that required specific node.js versions to run were not being skipped correctly but this was not an issue in practice as the tests were not being run anyway.