Remove all leftovers of pinned-dependencies handling #7686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
force-pushed
the
remove-pinned-dependencies
branch
from
c6d90d4 to
4e950ff
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
cknitt
force-pushed
the
remove-pinned-dependencies
branch
from
4e950ff to
127fd6a
Compare
zth
approved these changes
Jul 22, 2025
Bushuo
reviewed
Jul 22, 2025
| source_file.implementation.parse_state = ParseState::Warning; | ||
| source_file.implementation.parse_dirty = true; | ||
| logs::append(package, &stderr_warnings); | ||
| stderr.push_str(&stderr_warnings); | ||
| } | ||
| Ok((_path, Some(_))) | Ok((_path, None)) => { | ||
| // If we do have stderr_warnings here, the file is not a pinned | ||
| // dependency (so some external dep). We can ignore those |
There was a problem hiding this comment.
Ah, that's where the warnings got swallowed previously.
Bushuo
approved these changes
Jul 22, 2025
|
@cknitt The |
|
@Bushuo Thanks! Updated. |
# Conflicts: # rewatch/src/build/packages.rs
cknitt
force-pushed
the
remove-pinned-dependencies
branch
from
426ac3b to
99cc34b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinned-dependencies have not really have any effect in bsb for some time.
Therefore I removed all occurrences of pinned dependencies from the codebase.
In rewatch, replaced
is_pinned_depandis_pinned_dep || is_local_depwithis_local_depeverywhere.