Remove meth attribute #7684
Merged
Remove meth attribute #7684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shulhi
force-pushed
the
remove-meth
branch
2 times, most recently
from
cd49ea0 to
bd837e2
Compare
|
This looks fine -- notice it will conflict a couple of lines with this commit that cleans up the arity inference, and uses the existing arity instead: 8a7ac4a That's when I noticed that |
shulhi
force-pushed
the
remove-meth
branch
5 times, most recently
from
6a97c31 to
6ab595d
Compare
|
@shulhi Could you add a CHANGELOG entry and update the analysis test snapshots? |
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
cknitt
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
@methattribute and it will remove the usage automatically when the formatter is run.