Skip to content

Fix issue with preserve mode where jsx is declared as an external w… #7591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

Fix issue with preserve mode where jsx is declared as an external w… #7591

merged 1 commit into from
Jul 3, 2025

Conversation

cristianoc
Copy link
Collaborator

…ithout a @module attribute

Fixes #7577

@cristianoc cristianoc force-pushed the preserve_mode_jsx branch from 9338d4f to 13d880d Compare July 3, 2025 12:32
@cristianoc cristianoc requested a review from nojaf July 3, 2025 12:32
@cristianoc cristianoc mentioned this pull request Jul 3, 2025
Closed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 3, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7591

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7591

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7591

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7591

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7591

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7591

commit: 13d880d

nojaf
nojaf approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, it was in js_dump after all.
Thanks @cristianoc!

@cristianoc cristianoc merged commit 50c72c5 into master Jul 3, 2025
17 checks passed
@cristianoc cristianoc deleted the preserve_mode_jsx branch July 3, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianoc @nojaf