Skip to content

Promise.t -> promise #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

Promise.t -> promise #24

merged 1 commit into from
Nov 29, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Nov 29, 2024

Directly use the built-in type promise instead of the alias Promise.t everywhere.

@cknitt cknitt requested a review from nojaf November 29, 2024 16:34
nojaf
nojaf approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you so much!

@nojaf nojaf merged commit e13fb00 into main Nov 29, 2024
2 checks passed
@cknitt cknitt deleted the promise branch November 29, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @nojaf