Skip to content

Conversation

kstark
Copy link

@kstark kstark commented Dec 4, 2015

This was causing issues with our instrumentation.

It wasn't 100% clear to me how to handle close raising an exception, so I think there's a chance that abort might be called twice.

@tseaver
Copy link
Member

tseaver commented Jun 3, 2016

Thanks for the patch! Could you add a unit test showing that the iterable gets closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants