Skip to content

Conversation

@Saveli0S
Copy link
Contributor

@Saveli0S Saveli0S commented Oct 31, 2025

Summary by CodeRabbit

  • New Features

    • Added three new icons to the component library for use in the UI.
  • Style

    • Introduced a new theme color for the "skipped" test status (may affect display if the value is malformed).

@coderabbitai
Copy link

coderabbitai bot commented Oct 31, 2025

Walkthrough

Added a new CSS custom property in :root for skipped test status (value includes a malformed token: double hash and extra semicolon) and exported three SVG icon components: TestPlanIcon, OwnerIcon, and LaunchTypeIcon.

Changes

Cohort / File(s) Change Summary
Theme CSS Variables
src/assets/styles/themes/base.scss
Added new CSS custom property --rp-ui-base-test-execution-status-skipped to :root. The inserted value contains a double hash and an extra semicolon (malformed token).
Icon Exports
src/components/icons/index.ts
Added three new exports: TestPlanIcon from ./svg/testPlan.svg, OwnerIcon from ./svg/owner.svg, and LaunchTypeIcon from ./svg/launchType.svg.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Areas to check:

  • src/assets/styles/themes/base.scss — verify the new custom property's value syntax and intended color (remove extra # and stray ; if present).
  • src/components/icons/index.ts — confirm exported identifiers, import paths, and that referenced SVG files exist and build correctly.

Possibly related PRs

  • ui-kit#108 — also modifies src/components/icons/index.ts to add SVG icon exports (same file/pattern).
  • ui-kit#113 — adds new icon exports to src/components/icons/index.ts following the same export pattern.
  • ui-kit#97 — modifies src/assets/styles/themes/base.scss by adding CSS custom properties to :root.

Suggested reviewers

  • AmsterGet
  • maria-hambardzumian
  • allaprischepa
  • OleksandrDragun
  • ViktorSoroka07

Poem

🐰 A tiny hop, three icons gleam,

A skipped-test gray within the theme,
New exports snug in tidy rows,
The stylesheet hums where color grows,
I nibble pixels — off they stream!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check ❓ Inconclusive The title "add lauch side-panel variables" is vague and only partially describes the actual changeset. The PR makes two distinct types of changes: adding a CSS custom property for test execution status and exporting three new icon components. The term "side-panel variables" is non-specific and does not clearly convey what variables are being added or their purpose. Additionally, the title does not reference the icon exports at all, leaving it unclear whether the title is intended to cover the entire changeset or only a portion of it. There is also a typo in the title ("lauch" instead of "launch"). Consider revising the title to be more specific and descriptive of all changes. A clearer title might specify both the CSS variable addition and icon exports, such as "add test execution status variable and icon exports" or similar, which would make it immediately clear what the changeset introduces and help team members scanning the history understand the scope of changes without confusion.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch launch-panel-variables

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98bf013 and 5802323.

📒 Files selected for processing (1)
  • src/assets/styles/themes/base.scss (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/assets/styles/themes/base.scss

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8dc795b and 98bf013.

⛔ Files ignored due to path filters (3)
  • src/components/icons/svg/launchType.svg is excluded by !**/*.svg
  • src/components/icons/svg/owner.svg is excluded by !**/*.svg
  • src/components/icons/svg/testPlan.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • src/assets/styles/themes/base.scss (1 hunks)
  • src/components/icons/index.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-12T09:26:25.862Z
Learnt from: allaprischepa
Repo: reportportal/ui-kit PR: 125
File: src/assets/styles/themes/dark.scss:25-25
Timestamp: 2025-08-12T09:26:25.862Z
Learning: In the reportportal/ui-kit project, light and dark themes intentionally use different base token naming patterns. For example, --rp-ui-color-field-bg-3 maps to --rp-ui-base-dark-bg-solid-96 in dark theme but to --rp-ui-base-bg-000 in light theme, following the design mockups' naming conventions.

Applied to files:

  • src/assets/styles/themes/base.scss
📚 Learning: 2025-08-12T09:33:21.976Z
Learnt from: allaprischepa
Repo: reportportal/ui-kit PR: 125
File: src/components/fieldTextFlex/fieldTextFlex.module.scss:35-37
Timestamp: 2025-08-12T09:33:21.976Z
Learning: In the reportportal/ui-kit project, --rp-ui-base-error is used directly for error states rather than using theme-level error tokens like --rp-ui-color-error. This is an intentional design decision.

Applied to files:

  • src/assets/styles/themes/base.scss
📚 Learning: 2025-07-03T14:50:52.870Z
Learnt from: allaprischepa
Repo: reportportal/ui-kit PR: 107
File: src/components/datePicker/header/datePickerHeader.module.scss:60-64
Timestamp: 2025-07-03T14:50:52.870Z
Learning: For the reportportal/ui-kit project, when reviewing PRs related to font-weight variables, focus only on font-weight related changes and skip reviewing other CSS variables unless specifically requested.

Applied to files:

  • src/assets/styles/themes/base.scss
🔇 Additional comments (1)
src/components/icons/index.ts (1)

64-66: All SVG files verified to exist.

The new icon exports at lines 64-66 reference valid SVG files in the svg directory:

  • ✓ testPlan.svg
  • ✓ owner.svg
  • ✓ launchType.svg

Code is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants