-
Notifications
You must be signed in to change notification settings - Fork 1
add lauch side-panel variables #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughAdded a new CSS custom property in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Areas to check:
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
src/components/icons/svg/launchType.svgis excluded by!**/*.svgsrc/components/icons/svg/owner.svgis excluded by!**/*.svgsrc/components/icons/svg/testPlan.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
src/assets/styles/themes/base.scss(1 hunks)src/components/icons/index.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-12T09:26:25.862Z
Learnt from: allaprischepa
Repo: reportportal/ui-kit PR: 125
File: src/assets/styles/themes/dark.scss:25-25
Timestamp: 2025-08-12T09:26:25.862Z
Learning: In the reportportal/ui-kit project, light and dark themes intentionally use different base token naming patterns. For example, --rp-ui-color-field-bg-3 maps to --rp-ui-base-dark-bg-solid-96 in dark theme but to --rp-ui-base-bg-000 in light theme, following the design mockups' naming conventions.
Applied to files:
src/assets/styles/themes/base.scss
📚 Learning: 2025-08-12T09:33:21.976Z
Learnt from: allaprischepa
Repo: reportportal/ui-kit PR: 125
File: src/components/fieldTextFlex/fieldTextFlex.module.scss:35-37
Timestamp: 2025-08-12T09:33:21.976Z
Learning: In the reportportal/ui-kit project, --rp-ui-base-error is used directly for error states rather than using theme-level error tokens like --rp-ui-color-error. This is an intentional design decision.
Applied to files:
src/assets/styles/themes/base.scss
📚 Learning: 2025-07-03T14:50:52.870Z
Learnt from: allaprischepa
Repo: reportportal/ui-kit PR: 107
File: src/components/datePicker/header/datePickerHeader.module.scss:60-64
Timestamp: 2025-07-03T14:50:52.870Z
Learning: For the reportportal/ui-kit project, when reviewing PRs related to font-weight variables, focus only on font-weight related changes and skip reviewing other CSS variables unless specifically requested.
Applied to files:
src/assets/styles/themes/base.scss
🔇 Additional comments (1)
src/components/icons/index.ts (1)
64-66: All SVG files verified to exist.The new icon exports at lines 64-66 reference valid SVG files in the svg directory:
- ✓ testPlan.svg
- ✓ owner.svg
- ✓ launchType.svg
Code is ready to merge.
Summary by CodeRabbit
New Features
Style