-
Notifications
You must be signed in to change notification settings - Fork 105
Arbitrary secret key refs and templating in collectors #1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrary secret key refs and templating in collectors #1895
Conversation
d7c6cf8
to
55dbd2a
Compare
As an example, you can create a cluster using the replicated CLI and run
to apply the secrets there, and then run
which will generate a support bundle with the following files and content postgres-with-secret.json
|
// These will be properly defined as we expand v1beta3 support | ||
type AfterCollection struct { | ||
CollectorMeta `json:",inline" yaml:",inline"` | ||
// TODO: Add fields as needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few TODOs here. Are these needed at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structs are needed as there was a problem with how v1beta3 was loaded previously, since it wasnt using the loader like v1beta2 was apparently, and adding a lot of fields here would take a lot of extra time to do and test and be too much of a branch for this PR so I left them as TODOs after confirming it still behaves the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description, Motivation and Context
Enable collectors that require sensitive connection details, like passwords and TLS certs, without embedding them in specs, unlocking DB diagnostics in production clusters.
Based off of this issue:
https://github.com/replicated-collab/cohere-replicated/issues/48
Checklist
Does this PR introduce a breaking change?