Fix ollama windows installer #1894
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows requires files to be closed before they can be executed. This fix ensures the temporary installer file is properly closed before attempting to run it, preventing file access errors on Windows systems.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| // Close the file before executing it (required on Windows) | ||
| tmpFile.Close() | ||
|
|
There was a problem hiding this comment.
Bug: Temporary File Leak Causes Deletion Failures
Removing defer tmpFile.Close() introduces a resource leak. If errors occur during download, HTTP status check, or writing the installer, the temporary file handle remains open. On Windows, this can prevent os.Remove from successfully deleting the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
This PR fixes a critical bug in the Ollama installer for Windows systems. On Windows, files must be explicitly closed before they can be executed. Without this fix, attempting to run the Ollama installer fails because the temporary installer file is still open, causing file access errors.
The Problem:
When downloading and installing Ollama on Windows, the temporary installer file was being executed immediately after writing without closing the file handle first. Windows locks open files and prevents execution, causing the installation to fail.
The Solution:
Added an explicit
tmpFile.Close()call before attempting to execute the installer. This ensures the file handle is properly released and the installer can be executed successfully.Impact:
Checklist
Does this PR introduce a breaking change?