Fix windows cronjob #1891
Merged
Fix windows cronjob #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bennyyang11
force-pushed
the
fix-windows-cronjob
branch
from
83f0001 to
c27fad2
Compare
NoaheCampbell
requested changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Fixes an issue where scheduled support bundle jobs fail on Windows when using auto-discovery mode (
--autoflag).Problem:
When auto-discovery creates collectors with wildcard selectors (e.g.,
[]string{"*"}to collect all configmaps/secrets), the*character is used in error filenames likeconfigmaps-errors/default/*.json. Windows filesystems do not allow*in filenames, causing the scheduled job to fail with: CreateFile ...configmaps-errors\default*.json: The filename, directory name, or volume label syntax is incorrect.Solution:
Modified
selectorToString()inpkg/collect/util.goto sanitize Windows-invalid filename characters (< > : " / \ | ? *):*is replaced withall(semantic: "all resources")_This ensures cross-platform compatibility for scheduled jobs while maintaining semantic clarity in filenames.
Testing:
configmaps-errors/default/*.jsontoconfigmaps-errors/default/all.jsonChecklist
Does this PR introduce a breaking change?