chore(cmx): Remove 'network create/rm/join' commands #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
network create
,network rm
andnetwork join
commands. This moves these actions entirely into thevm create
andcluster create
paths.If a user wants to create a network they can do so by using the
vm/cluster create
CLI, to join to an existing network they can still specify--network
as part of that creation process.The
network ls
command has been retained to allow users to view their network policies and see an overall list of networks affiliated with running clusters/vms. Networks expire when the last VM/cluster affiliated with them is set to expire, because of this I've removed theEXPIRES
column within networks since it can be updated/modified based on modifying anything joined to it, it makes more sense for the user to associate cluster/vm expiration with a TTL value. I've kept theexpires_at
struct key for troubleshooting vials -ojson
if desired.This change also deprecates the
network update outbound
command in favor ofnetwork update policy
.