-
Notifications
You must be signed in to change notification settings - Fork 28
Edit docs on using the proxy registry #3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@@ -1,64 +1,32 @@ | |||
import StepCreds from "../partials/proxy-service/_step-creds.mdx" | |||
import StepCustomDomain from "../partials/proxy-service/_step-custom-domain.mdx" | |||
import RewriteHelmValues from "../partials/proxy-service/_step-rewrite-helm-values.mdx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulls in the new partial that has the step on how to modify image refs in your helm values
|
||
## Overview | ||
|
||
With the Replicated proxy registry, each customer's unique license can grant proxy access to images in an external private registry. | ||
During Helm installations with Replicated, after customers provide their unique license ID, a `global.replicated.dockerconfigjson` field that contains a base64 encoded Docker configuration file is automatically injected in the Helm chart values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor rewording in overview section mainly to try to remove extra info/words
|
||
1. <StepCreds/> | ||
|
||
1. <StepCustomDomain/> | ||
|
||
1. In your Helm chart values file, set your image repository URL to the location of the image on the proxy registry. If you added a custom domain, use your custom domain. Otherwise, use `proxy.replicated.com`. | ||
1. <RewriteHelmValues/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ replaced with the partial
|
||
# Use the Proxy Registry with KOTS Installations | ||
# Use the Proxy Registry with Replicated Installers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with KOTS Installations --> with Replicated Installers
Open to other suggestions on wording. Goal is to avoid using "KOTS" to actually mean KOTS/EC/kURL
|
||
## Overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some deleting/shuffling so this no longer needs such a big overview section
Instead, jumps right into the steps on how to configure your app to use the proxy, with a couple other subheadings for the non-HelmChart v2 apps
|
||
<details> | ||
|
||
<summary>How does KOTS patch image names?</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ adds all this info to a details element
## Enable the Proxy Registry | ||
|
||
This section describes how to enable the proxy registry for applications deployed with KOTS, including how to ensure that image names are rewritten and that the required image pull secret is provided. | ||
### Kubernetes Operators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left in the k8s operator stuff. Not sure if anyone's still using them/if this could be removed yet
If it can be removed, that would of course make it easier to further simplify this page
|
||
### Image Pull Secret | ||
If you are installing with the HelmChart v1 custom resource, or if your application is not packaged with Helm, there are different steps for configuring your application to use the proxy registry. See [Configure Other Application Types](#other) below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ I landed on a main "Configure Your App" section that assumes Helm app and HelmChart v2. And then links people that use other packaging/install methods down to the "other" options
My thought is that it highlights the main path that we expect most people to follow while minimizing noise of other possibilities
Open to suggestions on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still need to review the replicated installers page, but might be headed to the hopsital this morning, so i'll submit this for now.
@@ -1,64 +1,32 @@ | |||
import StepCreds from "../partials/proxy-service/_step-creds.mdx" | |||
import StepCustomDomain from "../partials/proxy-service/_step-custom-domain.mdx" | |||
import RewriteHelmValues from "../partials/proxy-service/_step-rewrite-helm-values.mdx" | |||
|
|||
# Use the Proxy Registry with Helm Installations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing that could clarify the docs a bit is if we said something like "with Helm CLI installations." i know helm is all over the place now, and people are using helm for all installation methods, so maybe that would clear up the fact that this is when you're using helm install
directly. just a thought.
Previews: