feat(api): validate required app config items #2472
+1,864
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
commented
Jul 14, 2025
| @@ -137,7 +137,7 @@ wait_for_pods_running() { | |||
| current_time=$(date +%s) | |||
| elapsed_time=$((current_time - start_time)) | |||
| if [ "$elapsed_time" -ge "$timeout" ]; then | |||
| kubectl get pods -A -o yaml || true | |||
| kubectl get pods -A || true | |||
emosbaugh
commented
Jul 14, 2025
Comment on lines
+190
to
+193
| // TODO: should an item really not be required if it's hidden? | ||
| if item.Hidden || item.When == "false" { | ||
| return false | ||
| } |
There was a problem hiding this comment.
This is how KOTS works today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
API support and validation for required items
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?