Skip to content

chore: Config item component improvements #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

screspod
Copy link
Member

@screspod screspod commented Jul 11, 2025

What this PR does / why we need it:

  • Makes Radio and Checkbox their own components
  • Creates a high order component ConfigItem that injects props that are shared among Input, Textarea, Checkbox, and Radio (id, label, help_text)
  • Adds help text support to Textarea, Checkbox and Radio
  • Fixes bug in Checkbox and Radio where the incorrect accent color is being used.

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/126513/repurpose-input-component
https://app.shortcut.com/replicated/story/126358/support-the-help-text-config-item-property

Does this PR require a test?

NONE

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

@screspod screspod force-pushed the screspod/sc-126513/repurpose-input-component branch from 615ea38 to 44650b8 Compare July 11, 2025 18:25
@screspod screspod force-pushed the screspod/sc-126513/repurpose-input-component branch from 44650b8 to 0dd56ea Compare July 11, 2025 18:27
Copy link

github-actions bot commented Jul 11, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-9b5d86a" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-9b5d86a?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@screspod screspod marked this pull request as ready for review July 11, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant