Skip to content

chore(web): consistent usage of the intial state context #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JGAntunes
Copy link
Member

What this PR does / why we need it:

Quick cleanup of the initial state context component:

  • Renamed it from Branding* to what it actually is (Initial State)
  • Added some types and type guards
  • Use the InitialStateContext everywhere instead of accessing window.* directly.
  • Some tests
  • Some type cleanups.

Which issue(s) this PR fixes:

NA

Does this PR require a test?

Adds tests

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

@JGAntunes JGAntunes requested review from miaawong and sgalsaleh July 11, 2025 18:06
@JGAntunes JGAntunes self-assigned this Jul 11, 2025
@JGAntunes JGAntunes marked this pull request as draft July 11, 2025 18:11
@JGAntunes JGAntunes marked this pull request as ready for review July 11, 2025 18:20
Copy link
Member

@diamonwiggins diamonwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-5337789" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-5337789?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants