only auto scroll if at bottom of logs

[ajp-io]

What this PR does / why we need it:

It was impossible to scroll back through installation logs during an install, because every time a new log line was added, it would scroll you back to the bottom.

With this change, we only auto-scroll if you're already at the bottom.

Which issue(s) this PR fixes:

Does this PR require a test?

NONE

Does this PR require a release note?

Does this PR require documentation?

NONE

[github-actions]

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-de90c6c" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-de90c6c?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

[Copilot]

Pull Request Overview

This PR enhances the log viewer so that it only auto-scrolls to new entries when the user is already at the bottom of the log pane, preventing unwanted repositioning when browsing historical entries.

• Added isAtBottom state and handleScroll to track scroll position.
• Updated the auto-scroll effect to consider isAtBottom before scrolling.
• Attached ref and onScroll to the log container to monitor user scroll.

Comments suppressed due to low confidence (2)

web/src/components/wizard/installation/shared/LogViewer.tsx:22

• [nitpick] The function name 'handleScroll' is generic. Consider renaming it to 'handleLogContainerScroll' or 'onLogContainerScroll' to better convey its purpose.

  const handleScroll = () => {

web/src/components/wizard/installation/shared/LogViewer.tsx:35

• Consider adding unit or integration tests to verify that auto-scrolling only occurs when the user is at the bottom and is disabled when scrolled up, ensuring this behavior remains covered.

  }, [logs, isExpanded, isAtBottom]);

[Copilot]

[nitpick] The threshold value '10' is a magic number. Extract it into a named constant (e.g., SCROLL_THRESHOLD) to improve readability and make future adjustments easier.

Suggested change

	const isBottom = Math.abs(scrollHeight - clientHeight - scrollTop) < 10;
	const isBottom = Math.abs(scrollHeight - clientHeight - scrollTop) < SCROLL_THRESHOLD;