Use cached wallet_getCapabilities #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed hardcoded userOperation hash value in wallet_getCallsStatus to the value returned from last successful call to wallet_sendCalls
Action wallet_getCapabilities will return cached data from session.sessioProperties if present else it will send a call to wallet to get the capabilities. Added RequestLoaderModal.tsx for waiting for request to get fulfil from the wallet, this modal have different message, RequestModal can be refactored to support both, but for simplicity created a separate modal to handle request which don't need a user action
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
arein
reviewed
Apr 24, 2024
There was a problem hiding this comment.
The wallet_getCapabilities "caching" should ultimately move into the provider. No concern with this PR but @KannuSingh can you leave a comment in the code reminding us to clean up after it's done.
@ganchoradkov the ERC is in review now. When do you think is the right time to move this logic into the provider?
| @@ -0,0 +1,52 @@ | |||
| import * as React from "react"; | |||
There was a problem hiding this comment.
looks very similar to the old one - why a new one?
There was a problem hiding this comment.
its just some text changes on the modal, it don't need any approval or reject action on wallet side.
I can refactor the old one to take these messages as props.
lukaisailovic
approved these changes
Apr 24, 2024
bkrem
reviewed
Apr 24, 2024
| @@ -518,15 +518,21 @@ export function JsonRpcContextProvider({ | |||
| } | |||
|
|
|||
| const params = [address] | |||
| // check the session.sessioProperties first for capabilities | |||
There was a problem hiding this comment.
Suggested change
| // check the session.sessioProperties first for capabilities | |
| // check the session.sessionProperties first for capabilities |
| @@ -548,8 +554,9 @@ export function JsonRpcContextProvider({ | |||
| `Missing rpcProvider definition for chainId: ${chainId}` | |||
| ); | |||
| } | |||
| if(lastTxId == undefined) throw new Error(`Last transaction id ${lastTxId}, make sure call to sendCalls returns successfully. `); | |||
| //hardcoded valid userOpHash | |||
There was a problem hiding this comment.
No longer hardcoded based on the change (I presume)
Suggested change
| //hardcoded valid userOpHash |
| @@ -548,8 +554,9 @@ export function JsonRpcContextProvider({ | |||
| `Missing rpcProvider definition for chainId: ${chainId}` | |||
| ); | |||
| } | |||
| if(lastTxId == undefined) throw new Error(`Last transaction id ${lastTxId}, make sure call to sendCalls returns successfully. `); | |||
There was a problem hiding this comment.
Better to use === strict comparison here if the possible values are string | undefined
Suggested change
| if(lastTxId == undefined) throw new Error(`Last transaction id ${lastTxId}, make sure call to sendCalls returns successfully. `); | |
| if (lastTxId === undefined) throw new Error(`Last transaction ID is undefined, make sure previous call to sendCalls returns successfully. `); |
bkrem
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action wallet_getCapabilities will return cached data from session.sessioProperties if present else it will send a call to wallet to get the capabilities.
Added RequestLoaderModal.tsx for waiting for request to get fulfil from the wallet, this modal have different display message, RequestModal can be refactored to support both, but for simplicity created a separate modal to handle request which don't need a user action