-
Notifications
You must be signed in to change notification settings - Fork 95
docs: update onramp documentation to reflect Coinbase removal #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: update onramp documentation to reflect Coinbase removal #566
Conversation
- Remove Coinbase as onramp provider option since it's now available under Meld - Update provider selection text to only mention Meld - Update purchase completion text to reference Meld only References: reown-com/appkit@79926ba Co-Authored-By: unknown <>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
@devin-ai-integration[bot] Please review the tone of voice for the content changes in this PR against Reown's brand guidelines. 📝 Content Review RequestFiles to review: 1
Review focus:
Guidelines summary:
Please analyze the content changes and provide constructive feedback on tone and voice alignment. |
🤖 Tone of Voice Review ResponseI've reviewed the content changes in this PR against Reown's brand guidelines: Changes Made:
Tone Analysis: Alignment Assessment:
No tone adjustments needed - the changes successfully update factual content while preserving Reown's established voice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the AppKit onramp documentation to remove references to Coinbase OnRamp now that Coinbase has been consolidated under Meld.
- Changed provider selection text to only mention Meld
- Updated purchase instructions to reference only Meld
- (Context) The screenshot remains the same but may need updating
Comments suppressed due to low confidence (1)
appkit/features/onramp.mdx:85
- Verify that
/images/new-onramp.png
no longer displays Coinbase as an option. If it does, replace it with an updated screenshot showing only Meld.
<img src="/images/new-onramp.png" />
@@ -79,15 +79,15 @@ Once connected, select "Buy Crypto" from the wallet modal. | |||
|
|||
### Choose your provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this page will be deleted
no action need for the moment
Thanks for the heads up @rtomas! I understand that this entire onramp page will be deleted soon, which would make these changes obsolete. Since you mentioned no action is needed for the moment, I'll leave this PR as-is for now. For context: This PR was created automatically based on commit 79926ba3de4d7af6ae14a61118ca8c30d183a0ba in the appkit repository, which removed Coinbase OnRamp functionality. The automation detected this as a documentation-impacting change and created this PR to keep docs in sync. If you'd prefer to close this PR given the planned page deletion, please let me know and I can close it. Otherwise, it can remain open until the page deletion occurs. |
docs: update onramp documentation to reflect Coinbase removal
Summary
This PR updates the AppKit onramp documentation to reflect the removal of Coinbase OnRamp functionality from the AppKit SDK. Based on commit 79926ba3de4d7af6ae14a61118ca8c30d183a0ba, Coinbase OnRamp was removed since it's now available under Meld's options, simplifying the onramp provider system.
Changes made:
Review & Testing Checklist for Human
/images/new-onramp.png
shows outdated UI - The image may still display Coinbase as an option, which would be inconsistent with the updated textDiagram
Notes
Link to Devin run: https://app.devin.ai/sessions/6ca8980195164cfeabbc3e9c463d4fc3
Requested by: User via Slack automation